WIP Detach tty #302
Open
WIP Detach tty #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarbat
approved these changes
Mar 14, 2018
kano_updater/utils.py
Outdated
| Detach from controlling tty | ||
| """ | ||
| try: | ||
| myTTY = os.open("/dev/tty",os.O_RDWR) |
There was a problem hiding this comment.
Should this be broadly better if queried dynamically? To support docker interactive builds.
kanux@minos:~$ peldins-jessie
Started container: peldins-jessie with command: 'bash'
update-binfmts: warning: qemu-arm already enabled in kernel.
kanux@4f73998cc87b:~/peldins-jessie$ tty
/dev/pts/12
There was a problem hiding this comment.
/dev/tty is a magic file which represents the tty attached to the current process.
|
@Ealdwulf I've manually added your changes on top of the current |
tombettany
force-pushed
the
master
branch
2 times, most recently
from
7ec798f to
9cbd4a7
Compare
tombettany
force-pushed
the
master
branch
2 times, most recently
from
d85541f to
cc8cf39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I forget, I think this could make the updater slightly more immune to packages asking interactive questions.
NOT proposing to merge for this rc, we've done enough to the updater already.
This PR: